giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alessandro Presta" <alessan...@fb.com>
Subject Re: Review Request 13248: Added support for matrix aggregators. We use one aggregator per row and handle the aggregation of entries. The types supported are int, long, float, double.
Date Tue, 06 Aug 2013 03:05:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13248/#review24694
-----------------------------------------------------------


One more suggestion.


giraph-core/src/main/java/org/apache/giraph/aggregators/matrix/DoubleMatrixSumAggregator.java
<https://reviews.apache.org/r/13248/#comment48807>

    I would add a getRowAggregatorName(i) method. I know it's more characters to type but
it's more robust.
    You can put that in a common abstract class (MatrixSumAggregator). name will be a field
of that class, and you call super(name) in the children constructors.
    Makes sense?


- Alessandro Presta


On Aug. 5, 2013, 9:01 p.m., Herald Kllapi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13248/
> -----------------------------------------------------------
> 
> (Updated Aug. 5, 2013, 9:01 p.m.)
> 
> 
> Review request for giraph.
> 
> 
> Repository: giraph-git
> 
> 
> Description
> -------
> 
> In applications where a matrix is needed, is not efficient to have an aggregator per
entry. This update provides the same functionality with an aggregator per matrix row.
> 
> 
> Diffs
> -----
> 
>   giraph-core/src/main/java/org/apache/giraph/aggregators/matrix/DoubleMatrix.java PRE-CREATION

>   giraph-core/src/main/java/org/apache/giraph/aggregators/matrix/DoubleMatrixSumAggregator.java
PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/aggregators/matrix/DoubleVector.java PRE-CREATION

>   giraph-core/src/main/java/org/apache/giraph/aggregators/matrix/DoubleVectorSumAggregator.java
PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/aggregators/matrix/FloatMatrix.java PRE-CREATION

>   giraph-core/src/main/java/org/apache/giraph/aggregators/matrix/FloatMatrixSumAggregator.java
PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/aggregators/matrix/FloatVector.java PRE-CREATION

>   giraph-core/src/main/java/org/apache/giraph/aggregators/matrix/FloatVectorSumAggregator.java
PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/aggregators/matrix/IntMatrix.java PRE-CREATION

>   giraph-core/src/main/java/org/apache/giraph/aggregators/matrix/IntMatrixSumAggregator.java
PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/aggregators/matrix/IntVector.java PRE-CREATION

>   giraph-core/src/main/java/org/apache/giraph/aggregators/matrix/IntVectorSumAggregator.java
PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/aggregators/matrix/LongMatrix.java PRE-CREATION

>   giraph-core/src/main/java/org/apache/giraph/aggregators/matrix/LongMatrixSumAggregator.java
PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/aggregators/matrix/LongVector.java PRE-CREATION

>   giraph-core/src/main/java/org/apache/giraph/aggregators/matrix/LongVectorSumAggregator.java
PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/aggregators/matrix/package-info.java PRE-CREATION

>   giraph-core/src/test/java/org/apache/giraph/aggregators/matrix/TestDoubleMatrix.java
PRE-CREATION 
>   giraph-core/src/test/java/org/apache/giraph/aggregators/matrix/TestFloatMatrix.java
PRE-CREATION 
>   giraph-core/src/test/java/org/apache/giraph/aggregators/matrix/TestIntMatrix.java PRE-CREATION

>   giraph-core/src/test/java/org/apache/giraph/aggregators/matrix/TestLongMatrix.java
PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/13248/diff/
> 
> 
> Testing
> -------
> 
> We provide test classes to test the functionality.
> 
> 
> Thanks,
> 
> Herald Kllapi
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message