giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Pavan Kumar (JIRA)" <>
Subject [jira] [Commented] (GIRAPH-868) Fix race condition with WorkerProgress
Date Fri, 07 Mar 2014 19:58:43 GMT


Pavan Kumar commented on GIRAPH-868:

Thanks for the fix

small comments:
can the definition be changed from
stop(String myProgressPath, ZooKeeperExt zk) to
stop(ZooKeeperExt zk, String myProgressPath) since writeToZnode has similar definition and
it would be less confusing that way.

also did u run checkstyle 
+  public void stop(String myProgressPath, ZooKeeperExt zk) throws
+      InterruptedException {

please run mvn clean verify before checking in.

> Fix race condition with WorkerProgress
> --------------------------------------
>                 Key: GIRAPH-868
>                 URL:
>             Project: Giraph
>          Issue Type: Bug
>            Reporter: Maja Kabiljo
>            Assignee: Maja Kabiljo
>         Attachments: GIRAPH-868.patch
> WorkerProgressWriter periodically updates progress and it can happen that it overwrites
the finished state written from the main thread, causing job client to wait indefinitely.

This message was sent by Atlassian JIRA

View raw message