giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GIRAPH-900) Remove timers for compute method
Date Sun, 08 Jun 2014 21:37:02 GMT

    [ https://issues.apache.org/jira/browse/GIRAPH-900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14021375#comment-14021375
] 

Hudson commented on GIRAPH-900:
-------------------------------

ABORTED: Integrated in Giraph-trunk-Commit #1447 (See [https://builds.apache.org/job/Giraph-trunk-Commit/1447/])
GIRAPH-900: Remove timers for compute method (majakabiljo via pavanka) (pavanka: http://git-wip-us.apache.org/repos/asf?p=giraph.git&a=commit&h=e4b8db5d8b34b33d7551d912e53fe198bb95d7e0)
* giraph-core/src/main/java/org/apache/giraph/metrics/TimerDesc.java
* giraph-core/src/main/java/org/apache/giraph/graph/ComputeCallable.java
* giraph-core/src/main/java/org/apache/giraph/metrics/AggregatedMetrics.java
* giraph-core/src/main/java/org/apache/giraph/metrics/WorkerSuperstepMetrics.java
* giraph-core/src/main/java/org/apache/giraph/metrics/GiraphMetricsRegistry.java
* CHANGELOG


> Remove timers for compute method
> --------------------------------
>
>                 Key: GIRAPH-900
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-900
>             Project: Giraph
>          Issue Type: Improvement
>            Reporter: Maja Kabiljo
>            Assignee: Maja Kabiljo
>             Fix For: 1.1.0
>
>         Attachments: GIRAPH-900.patch
>
>
> When processing on a single vertex is quick, having timers around each compute call is
very expensive - in some experiments supersteps run up to 40% faster without this timer. I
never found it useful since average times are usually short enough to not mean much, and also
it's not just user code time but when we block on sending requests it's counted here as well.
So I'm just removing it instead of making it optional.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message