giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GIRAPH-1166) Allow MasterObserver to get superstep aggregated metrics
Date Wed, 10 Jan 2018 23:26:00 GMT

    [ https://issues.apache.org/jira/browse/GIRAPH-1166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16321332#comment-16321332
] 

ASF GitHub Bot commented on GIRAPH-1166:
----------------------------------------

Github user yukselakinci commented on a diff in the pull request:

    https://github.com/apache/giraph/pull/55#discussion_r160827710
  
    --- Diff: giraph-core/src/main/java/org/apache/giraph/master/BspServiceMaster.java ---
    @@ -984,6 +984,9 @@ private GlobalStats aggregateWorkerStats(long superstep) {
           } else {
             printAggregatedMetricsToHDFS(superstep, aggregatedMetrics);
           }
    +      for (MasterObserver observer : observers) {
    +        observer.superstepMetricsUpdate(superstep, aggregatedMetrics);
    --- End diff --
    
    Should we catch exceptions here?


> Allow MasterObserver to get superstep aggregated metrics
> --------------------------------------------------------
>
>                 Key: GIRAPH-1166
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-1166
>             Project: Giraph
>          Issue Type: Improvement
>            Reporter: Maja Kabiljo
>            Assignee: Maja Kabiljo
>            Priority: Minor
>
> Pass superstep AggregatedMetrics to MasterObserver, to be able to analyze eg stragglers
in jobs.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message