giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GIRAPH-1181) Changes to ExtendedByteArrayDataOutput
Date Thu, 29 Mar 2018 00:10:00 GMT

    [ https://issues.apache.org/jira/browse/GIRAPH-1181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16418270#comment-16418270
] 

ASF GitHub Bot commented on GIRAPH-1181:
----------------------------------------

Github user majakabiljo commented on a diff in the pull request:

    https://github.com/apache/giraph/pull/65#discussion_r177864935
  
    --- Diff: giraph-core/src/main/java/org/apache/giraph/comm/aggregators/CountingOutputStream.java
---
    @@ -36,7 +36,7 @@
        * Default constructor
        */
       public CountingOutputStream() {
    -    dataOutput = new ExtendedByteArrayDataOutput();
    +    dataOutput = new UnsafeByteArrayOutputStream();
    --- End diff --
    
    I see a lot of changes in aggregators related classes, why are we changing those in this
diff?


> Changes to ExtendedByteArrayDataOutput
> --------------------------------------
>
>                 Key: GIRAPH-1181
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-1181
>             Project: Giraph
>          Issue Type: Improvement
>            Reporter: Yuksel Akinci
>            Priority: Major
>
> Adding a new stream type which extends from com.esotericsoftware.kryo.io.Input/Output,
so that it can be used with kryo serializer. It improves the performance of kryo by faster
read/writes (unsafe IO), and also eliminates the need for interim buffers to convert from DataInput
and DataOutput.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message