giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GIRAPH-1194) Improve ZK event logging in BspServiceMaster
Date Fri, 18 May 2018 22:00:00 GMT

    [ https://issues.apache.org/jira/browse/GIRAPH-1194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16481250#comment-16481250
] 

ASF GitHub Bot commented on GIRAPH-1194:
----------------------------------------

GitHub user dlogothetis opened a pull request:

    https://github.com/apache/giraph/pull/74

    Add logging in BspMaster

    https://issues.apache.org/jira/browse/GIRAPH-1194
    
    Every time there is a new event, like workers finishing the superstep, BspServiceMaster
logs the entire list of workers that have finishes. This is too verbose. We should print the
new workers each time.
    
    Tests:
    - mvn clean install -DskipTest
    - run job and verify logging


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dlogothetis/giraph bspmaster_log

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/giraph/pull/74.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #74
    
----
commit fb0662491e0c73d51e54b59f273d5efb414fed16
Author: Dionysios Logothetis <dlogothetis@...>
Date:   2018-04-25T15:33:21Z

    Add logging in BspMaster

----


> Improve ZK event logging in BspServiceMaster
> --------------------------------------------
>
>                 Key: GIRAPH-1194
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-1194
>             Project: Giraph
>          Issue Type: Improvement
>            Reporter: Dionysios Logothetis
>            Assignee: Dionysios Logothetis
>            Priority: Major
>
> Every time there is a new event, like workers finishing the superstep, BspServiceMaster
logs the entire list of workers that have finishes. This is too verbose. We should print the
new workers each time.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message