giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dlogothetis <...@git.apache.org>
Subject [GitHub] giraph pull request #87: Better exception handling for large number of edges...
Date Wed, 17 Oct 2018 17:31:05 GMT
Github user dlogothetis commented on a diff in the pull request:

    https://github.com/apache/giraph/pull/87#discussion_r226026086
  
    --- Diff: giraph-core/src/main/java/org/apache/giraph/edge/ByteArrayEdges.java ---
    @@ -94,6 +94,9 @@ public void add(Edge<I, E> edge) {
         } catch (IOException e) {
           throw new IllegalStateException("add: Failed to write to the new " +
               "byte array");
    +    } catch (NegativeArraySizeException negativeArraySizeException) {
    +      throw new IllegalStateException("add: Too many edges for a vertex, " +
    +        edge.getTargetVertexId() + "hence failed to write to byte array");
    --- End diff --
    
    ```suggestion
            edge.getTargetVertexId() + " hence failed to write to byte array");
    ```


---

Mime
View raw message