giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GIRAPH-1211) Make retrying to send network requests after timeout optional
Date Wed, 07 Nov 2018 06:05:00 GMT

    [ https://issues.apache.org/jira/browse/GIRAPH-1211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16677723#comment-16677723
] 

ASF GitHub Bot commented on GIRAPH-1211:
----------------------------------------

Github user dlogothetis commented on a diff in the pull request:

    https://github.com/apache/giraph/pull/93#discussion_r231388167
  
    --- Diff: giraph-core/src/main/java/org/apache/giraph/comm/netty/NettyClient.java ---
    @@ -1006,18 +1013,21 @@ public boolean apply(RequestInfo requestInfo) {
             return writeFuture != null && (!writeFuture.channel().isActive() ||
                 (writeFuture.isDone() && !writeFuture.isSuccess()));
           }
    -    }, networkRequestsResentForConnectionFailure);
    +    }, networkRequestsResentForConnectionFailure, true);
       }
     
       /**
        * Resend requests which satisfy predicate
        *  @param shouldResendRequestPredicate Predicate to use to check whether
        *                                     request should be resent
        * @param counter Counter to increment for every resent network request
    +   * @param resendProblematicRequest Whether to resend problematic request or
    +   *                                fail th job if such request is found
    --- End diff --
    
    ```suggestion
       *                                fail the job if such request is found
    ```


> Make retrying to send network requests after timeout optional
> -------------------------------------------------------------
>
>                 Key: GIRAPH-1211
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-1211
>             Project: Giraph
>          Issue Type: New Feature
>            Reporter: Maja Kabiljo
>            Assignee: Maja Kabiljo
>            Priority: Major
>
> Using counters added in GIRAPH-1205 we were able to confirm that resending network requests
after timeout almost never succeeds, so add an option to fail early instead of keep trying
to resend these network requests indefinitely.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message