giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [giraph] dlogothetis commented on a change in pull request #101: Make number of retries in RetryableJobProgressTrackerClient configurable
Date Wed, 08 May 2019 20:45:14 GMT
dlogothetis commented on a change in pull request #101: Make number of retries in RetryableJobProgressTrackerClient
configurable
URL: https://github.com/apache/giraph/pull/101#discussion_r282242206
 
 

 ##########
 File path: giraph-core/src/main/java/org/apache/giraph/graph/RetryableJobProgressTrackerClient.java
 ##########
 @@ -57,6 +68,10 @@
   private ThriftClientManager clientManager;
   /** Job progress tracker */
   private JobProgressTracker jobProgressTracker;
+  /** Cached value for number of retries */
+  private int numRetries = 1;
+  /** Cached value for wait time between retries */
+  private int retryWaitMsec;
 
 Review comment:
   We don't need to. It will get initialized in the constructor. For consistency in the style,
I will remove the initialization of numRertries too.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message