giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [giraph] majakabiljo commented on a change in pull request #107: Configure jmap path
Date Mon, 09 Sep 2019 15:18:18 GMT
majakabiljo commented on a change in pull request #107: Configure jmap path
URL: https://github.com/apache/giraph/pull/107#discussion_r322301956
 
 

 ##########
 File path: giraph-core/src/main/java/org/apache/giraph/utils/JMap.java
 ##########
 @@ -89,13 +94,16 @@ public static void heapHistogramDump(int numLines, PrintStream printStream)
{
    * @param numLines Number of lines to print
    * @param liveObjectsOnly Should we only print non GC-able objects?
    * @param printStream Stream to print to
+   * @param jmapPath Path to jmap binary
    */
   private static void heapHistogramDump(int numLines,
                                         boolean liveObjectsOnly,
-                                        PrintStream printStream) {
+                                        PrintStream printStream,
+                                        String jmapPath) {
     try {
       String args = liveObjectsOnly ? LIVE_HISTO_OPTION : ARGS;
-      Process p = Runtime.getRuntime().exec(CMD + args + getProcessId());
+      String cmd = jmapPath.isEmpty() ? CMD : (jmapPath + CMD);
 
 Review comment:
   Nit: maybe make the conf option JMAP_LOCATION with default "jmap"

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message