giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [giraph] dlogothetis commented on a change in pull request #110: Counter Mechanism
Date Mon, 28 Oct 2019 23:07:12 GMT
dlogothetis commented on a change in pull request #110: Counter Mechanism
URL: https://github.com/apache/giraph/pull/110#discussion_r339832194
 
 

 ##########
 File path: giraph-core/src/main/java/org/apache/giraph/worker/BspServiceWorker.java
 ##########
 @@ -1236,6 +1233,57 @@ public void cleanup(FinishedSuperstepStats finishedSuperstepStats)
       LOG.error("cleanup: Got InterruptedException on notification " +
           "to master about cleanup", e);
     }
+  }
+
+  /**
+   * Method to send the counter values to the master using the zookeeper
+   * This is called after finishing all the supersteps
+   *
+   */
+  public void sendCountersToMaster() {
 
 Review comment:
   nit: since this is really storing counters in ZK, and not sending to master directly, let's
change the name to reflect this.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message