giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [giraph] dlogothetis commented on a change in pull request #110: Counter Mechanism
Date Tue, 05 Nov 2019 19:00:50 GMT
dlogothetis commented on a change in pull request #110: Counter Mechanism
URL: https://github.com/apache/giraph/pull/110#discussion_r342740881
 
 

 ##########
 File path: giraph-core/src/main/java/org/apache/giraph/bsp/BspService.java
 ##########
 @@ -425,11 +431,20 @@ public final String getWorkerWroteCheckpointPath(long attempt,
    *
    * @param attempt application attempt number
    * @param superstep superstep to use
+   * @param readWriteCounters Boolean to denote whether we are
+   *                          reading/writing counters
    * @return directory path based on the a superstep
    */
-  public final String getWorkerFinishedPath(long attempt, long superstep) {
-    return applicationAttemptsPath + "/" + attempt +
+  public final String getWorkerFinishedPath(long attempt, long superstep,
 
 Review comment:
   Let's make a separate method that just returns the counters path. It seems clearer to separate
these two.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message