giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [giraph] dlogothetis commented on a change in pull request #110: Counter Mechanism
Date Tue, 05 Nov 2019 19:05:12 GMT
dlogothetis commented on a change in pull request #110: Counter Mechanism
URL: https://github.com/apache/giraph/pull/110#discussion_r342742808
 
 

 ##########
 File path: giraph-core/src/main/java/org/apache/giraph/bsp/CentralizedServiceWorker.java
 ##########
 @@ -256,4 +256,19 @@ void cleanup(FinishedSuperstepStats finishedSuperstepStats)
    */
   void addressesAndPartitionsReceived(
       AddressesAndPartitionsWritable addressesAndPartitions);
+
+  /**
+   * Send the counter values to the master after every superstep
+   * and also after all supersteps are done. This is called before closing
 
 Review comment:
   These comments don't describe exactly what the method does. We're not really sending to
the master.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message