giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [giraph] aanchal204 commented on a change in pull request #112: Make JobProgressTrackeClient implementation configurable
Date Wed, 06 Nov 2019 19:08:09 GMT
aanchal204 commented on a change in pull request #112: Make JobProgressTrackeClient implementation
configurable
URL: https://github.com/apache/giraph/pull/112#discussion_r343274548
 
 

 ##########
 File path: giraph-core/src/main/java/org/apache/giraph/conf/GiraphConstants.java
 ##########
 @@ -1201,6 +1203,13 @@
       new BooleanConfOption("giraph.trackJobProgressOnClient", false,
           "Whether to track job progress on client or not");
 
+  /** Class to use as the job progress client */
+  ClassConfOption<JobProgressTrackerClient> JOB_PROGRESS_TRACKER_CLIENT_CLASS =
+      ClassConfOption.create("giraph.jobProgressTrackerClientClass",
+        RetryableJobProgressTrackerClient.class,
+          JobProgressTrackerClient.class,
+          "Class to use to make calls to the job progress tracker service");
+
   /** Class to use to track job progress on client */
   ClassConfOption<JobProgressTrackerService> JOB_PROGRESS_TRACKER_CLASS =
 
 Review comment:
   As you are adding the JobProgressTrackerClient, can we rename this to JobProgressTrackerService,
to be clear about the difference between the two?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message