giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (Jira)" <j...@apache.org>
Subject [jira] [Commented] (GIRAPH-1231) incorrect imports from shaded guava
Date Wed, 13 May 2020 00:56:00 GMT

    [ https://issues.apache.org/jira/browse/GIRAPH-1231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17105854#comment-17105854
] 

Hudson commented on GIRAPH-1231:
--------------------------------

FAILURE: Integrated in Jenkins build Giraph-trunk-Commit #1804 (See [https://builds.apache.org/job/Giraph-trunk-Commit/1804/])
GIRAPH-1231 (dionysios: [http://gitbox.apache.org/repos/asf?p=giraph.git&a=commit&h=8dfb29047aec68859b439974594e38161359893a])
* (edit) giraph-block-app/src/main/java/org/apache/giraph/block_app/framework/internal/BlockMasterLogic.java
* (edit) giraph-block-app/pom.xml
* (edit) giraph-core/src/main/java/org/apache/giraph/worker/AllWorkersInfo.java
* (edit) giraph-core/src/main/java/org/apache/giraph/conf/DefaultMessageClasses.java
* (edit) giraph-core/src/main/java/org/apache/giraph/master/SuperstepClasses.java
* (edit) giraph-core/src/main/java/org/apache/giraph/reducers/impl/PairReduce.java
* (edit) giraph-block-app/src/test/java/org/apache/giraph/block_app/framework/BlockExecutionTest.java


> incorrect imports from shaded guava
> -----------------------------------
>
>                 Key: GIRAPH-1231
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-1231
>             Project: Giraph
>          Issue Type: Bug
>    Affects Versions: 1.2.0
>            Reporter: Jan Van Besien
>            Priority: Major
>         Attachments: giraph.guava.patch
>
>
> There are a number of imports throughout the code for guava utilities that use "import
org.python.google..." rather than "com.google...". Giraph already has a dependency on guava
and these imports only work due to the dependency on jython, which embeds a shaded guava.
>  
> I don't think that this is intentional, the jython guava dependency seems to be a different
(much older) version of guava as well.
>  
> In attachment a patch that fixes the issue.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message