giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dionysios Logothetis (Jira)" <j...@apache.org>
Subject [jira] [Commented] (GIRAPH-1231) incorrect imports from shaded guava
Date Fri, 08 May 2020 02:39:00 GMT

    [ https://issues.apache.org/jira/browse/GIRAPH-1231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17102185#comment-17102185
] 

Dionysios Logothetis commented on GIRAPH-1231:
----------------------------------------------

[~janvanbesien], thanks for reporting this. Do you want to create a github pull request with
your patch?

> incorrect imports from shaded guava
> -----------------------------------
>
>                 Key: GIRAPH-1231
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-1231
>             Project: Giraph
>          Issue Type: Bug
>    Affects Versions: 1.2.0
>            Reporter: Jan Van Besien
>            Priority: Major
>         Attachments: giraph.guava.patch
>
>
> There are a number of imports throughout the code for guava utilities that use "import
org.python.google..." rather than "com.google...". Giraph already has a dependency on guava
and these imports only work due to the dependency on jython, which embeds a shaded guava.
>  
> I don't think that this is intentional, the jython guava dependency seems to be a different
(much older) version of guava as well.
>  
> In attachment a patch that fixes the issue.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message