gora-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Enis Soztutar (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GORA-66) testDeleteByQueryFields seems incorrect
Date Mon, 09 Jan 2012 07:15:39 GMT

    [ https://issues.apache.org/jira/browse/GORA-66?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13182396#comment-13182396
] 

Enis Soztutar commented on GORA-66:
-----------------------------------

bq. I suppose first we need to determine whether this test should flush after the particular
call FOR ALL STORES. 

Yes, the test should call flush() for all stores. The semantics for delete, is like the semantics
for put(), in that, you have to call flush() or close() to make sure that the changes are
committed. 
                
> testDeleteByQueryFields seems incorrect
> ---------------------------------------
>
>                 Key: GORA-66
>                 URL: https://issues.apache.org/jira/browse/GORA-66
>             Project: Gora
>          Issue Type: Bug
>            Reporter: Keith Turner
>         Attachments: GORA-66-1.patch
>
>
> While writing the Accumulo backend I have been trying to run some of the existing test
against it.  It seems that the test DataStoreTestUtil.testDeleteByQueryFields() has two problems.
>  * The test does not flush the store after calling deleteByQuery().  This is needed for
accumulo since deletes are just inserts and must be flushed.
>  * The test expects the last key in a range that was deleted to be present.  As far as
I can tell the end key in a query should be inclusive, but the test treats as exclusive.
> I will submit a patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message