gora-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ferdy Galema <ferdy.gal...@kalooga.com>
Subject Re: [jira] [Commented] (GORA-120) Dirty fields are not correctly applied after serialization and map clearance
Date Thu, 19 Apr 2012 12:19:50 GMT
Sounds great!

On Thu, Apr 19, 2012 at 2:16 PM, Lewis John Mcgibbney <
lewis.mcgibbney@gmail.com> wrote:

> Ok Ferdy I'm working on this RC and nearly finished so will update to trunk
> and retest.
> Hopefully by end of play today we can VOTE on staged maven artifacts and
> src.tar.gz's and src.zip's yipeeeee
>
> Lewis
>
> On Thu, Apr 19, 2012 at 1:13 PM, Ferdy Galema <ferdy.galema@kalooga.com
> >wrote:
>
> > Ok I just committed it. I am stilling having trouble with local tests, so
> > we have to wait and see what Jenkins finds. I haven tested it succesfully
> > in a real life deployment though, so I don't except any pecularities.
> >
> > On Thu, Apr 19, 2012 at 10:51 AM, Lewis John Mcgibbney <
> > lewis.mcgibbney@gmail.com> wrote:
> >
> > > Hi Ferdy,
> > >
> > > I'm going to push on with the RC again today. so please feel free to
> > update
> > > trunk with the patch and run a test suite within the next hour or two.
> I
> > > had a look last night and I think it's a +1 from me.
> > >
> > > Thanks
> > >
> > > Lewis
> > >
> > > On Thu, Apr 19, 2012 at 7:15 AM, Ferdy Galema (Commented) (JIRA) <
> > > jira@apache.org> wrote:
> > >
> > > >
> > > >    [
> > > >
> > >
> >
> https://issues.apache.org/jira/browse/GORA-120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257287#comment-13257287
> > > ]
> > > >
> > > > Ferdy Galema commented on GORA-120:
> > > > -----------------------------------
> > > >
> > > > Hey Lewis,
> > > >
> > > > Thanks for noticing. GORA-33 exactly describes the first issue in the
> > > > list. "All entries in the map are incorrectly made dirty when a
> > > Persistent
> > > > is deserialized." I'll update the link.
> > > >
> > > > > Dirty fields are not correctly applied after serialization and map
> > > > clearance
> > > > >
> > > >
> > >
> >
> ----------------------------------------------------------------------------
> > > > >
> > > > >                 Key: GORA-120
> > > > >                 URL:
> https://issues.apache.org/jira/browse/GORA-120
> > > > >             Project: Apache Gora
> > > > >          Issue Type: Bug
> > > > >            Reporter: Ferdy Galema
> > > > >             Fix For: 0.3
> > > > >
> > > > >         Attachments: GORA-120-v1.txt
> > > > >
> > > > >
> > > > > Dirty fields are not correctly applied in these situations:
> > > > > -All entries in the map are incorrectly made dirty when a
> Persistent
> > is
> > > > deserialized.
> > > > > -Also, due to a separate bug all non-map entries that are
> > deserialized
> > > > are made dirty too. (This is pure coincidence as the bugs have
> > different
> > > > causes).
> > > > > -Finally, when a map is cleared but some entries that are put
> > > afterwards
> > > > are actually the same as before, it should be noticed as non-dirty.
> > (This
> > > > happens in Nutchgora a lot: getInlinks.clear(), getOutlinks.clear(),
> > > > getHeaders.clear() etc.).
> > > > > Because of this a lot of fields are dirty when they in fact are
> not.
> > It
> > > > is never the other way around. Therefore, this bug purely affects
> > > > performance.
> > > > > Patch will follow shortly. Let me know if you have any comments.
> > > >
> > > > --
> > > > This message is automatically generated by JIRA.
> > > > If you think it was sent incorrectly, please contact your JIRA
> > > > administrators:
> > > >
> > https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
> > > > For more information on JIRA, see:
> > > http://www.atlassian.com/software/jira
> > > >
> > > >
> > > >
> > >
> > >
> > > --
> > > *Lewis*
> > >
> >
>
>
>
> --
> *Lewis*
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message