gora-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ferdy Galema (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GORA-143) GoraCompiler needs to add "import FixedSize" statement for FIXED type
Date Mon, 09 Jul 2012 17:50:34 GMT

    [ https://issues.apache.org/jira/browse/GORA-143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13409681#comment-13409681
] 

Ferdy Galema commented on GORA-143:
-----------------------------------

+1 
I tested this and it works like a charm.

Two remarks:
-Like noted in the mailing list by Lewis please don't forget to add an entry to CHANGES.txt
-A small nit: Next time when committing you should put the issue number in the commit message
without a postfix. You postfixed a  "." (dot) which prevents it from being listed in this
issue as a commit.

Thanks!
                
> GoraCompiler needs to add "import FixedSize" statement for FIXED type
> ---------------------------------------------------------------------
>
>                 Key: GORA-143
>                 URL: https://issues.apache.org/jira/browse/GORA-143
>             Project: Apache Gora
>          Issue Type: Bug
>          Components: schema
>    Affects Versions: 0.2
>            Reporter: Kazuomi Kashii
>             Fix For: 0.3
>
>         Attachments: GORA-143-v2.patch, GORA-143.patch
>
>
> Since GoraCompiler does not write the following import statement:
> import org.apache.avro.specific.FixedSize;
> for FIXED type like:
>     { "name": "md5",       "type": { "type" : "fixed", "size" : 16, "name" : "MD5" }
},
> javac cannot compile the FIXED type class generated by GoraCompiler like:
> src/MD5.java:24: cannot find symbol
> symbol: class FixedSize
> @FixedSize(16)
>  ^
> GoraCompiler should write:
> import org.apache.avro.specific.FixedSize;

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message