gora-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henry Saputra (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GORA-283) Specify field name for types not being considered in gora-cassandra
Date Wed, 15 Jan 2014 18:27:19 GMT

    [ https://issues.apache.org/jira/browse/GORA-283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13872375#comment-13872375
] 

Henry Saputra commented on GORA-283:
------------------------------------

+1 LGTM

> Specify field name for types not being considered in gora-cassandra
> -------------------------------------------------------------------
>
>                 Key: GORA-283
>                 URL: https://issues.apache.org/jira/browse/GORA-283
>             Project: Apache Gora
>          Issue Type: Task
>          Components: gora-cassandra
>    Affects Versions: 0.4
>            Reporter: Lewis John McGibbney
>            Priority: Minor
>             Fix For: 0.4
>
>         Attachments: GORA-283.patch, GORA-283v2.patch
>
>
> Logging for the following code in the above method can easily be improved.
> {code}
> 443 	  default:
> 444 	    LOG.info("Type not considered: " + type.name());
> 445 	}
> {code}
> It should also provide the field.name(), something like
> LOG.info("Type not considered: " + type.name() + " for field: " field.name());
> I'll cook a patch and get it posted for review.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message