gora-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lewis John McGibbney (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GORA-94) Upgrade to Apache Avro 1.7.x
Date Thu, 06 Feb 2014 10:06:14 GMT

    [ https://issues.apache.org/jira/browse/GORA-94?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13893228#comment-13893228

Lewis John McGibbney commented on GORA-94:

bq. the builder initiate this field with null value. So, we always have to set a new HashMap
object to headers field at first. 
Duh, sorry about this one, I just didn't check the default value in the avro schema. You are
completely right with this one, thank you for clarification.

bq. I had fixed this problem in GORA-94v10.patch and it seems that it is clearing the dirty
states of all fields for now. Would you please elaborate this issue?
Well the v11 patch includes the following TODO
+      webPage.getHeaders().clear(); //TODO clear method does not work
I therefore wondered if this TODO should be removed?
Also I think we should make a decision on the other 2 TODO's regarding increments of local
variable *j*. This should be trivial to implement. 
Once this is done i think we are ready to get this code in to the code base as the tests are
well justified given the change in behavior of certain data structures which we have been
discussing over the last weeks. 

> Upgrade to Apache Avro 1.7.x
> ----------------------------
>                 Key: GORA-94
>                 URL: https://issues.apache.org/jira/browse/GORA-94
>             Project: Apache Gora
>          Issue Type: Improvement
>          Components: build process, storage
>    Affects Versions: 0.2
>            Reporter: Lewis John McGibbney
>            Assignee: Ed Kohlwey
>             Fix For: 0.4
>         Attachments: GORA-94-v2.patch, GORA-94-v3.patch, GORA-94-v4.patch, GORA-94.patch,
GORA-94v10.patch, GORA-94v11.patch, GORA-94v12.patch, GORA-94v6.diff, GORA-94v7.patch, GORA-94v8.patch,
GORA-94v9.patch, GORA_94v5.patch
> I am not sure what this involves as of yet but I have a small feeling that it's going
to be some reasonably major work...  

This message was sent by Atlassian JIRA

View raw message