gora-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Renato Javier Marroquín Mogrovejo (JIRA) <j...@apache.org>
Subject [jira] [Commented] (GORA-354) Clarify lowercasing of DataStoreFactory#findProperty
Date Thu, 31 Jul 2014 11:40:38 GMT

    [ https://issues.apache.org/jira/browse/GORA-354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14080767#comment-14080767

Renato Javier Marroquín Mogrovejo commented on GORA-354:

Sorry [~tpalsulich] for taking too long to come back to this.
1) I think all the properties' names should be lower case and users should be advised to do
so. Besides that. inside Gora we always check for lowercase properties' names anyway (or at
least we should. Maybe I will open another JIRA to fix those that are not). You are right
the cost of an extra is negligible in this case, but it's a cost that we shouldn't even "pay"
as Gora doesn't use non lowercase properties names. Class names (properties' values) capitalization
should be respected as this is used to do reflection in some places.
3) Block comments should be indented at the same level as the surrounding code. Thanks Tyler!

> Clarify lowercasing of DataStoreFactory#findProperty
> ----------------------------------------------------
>                 Key: GORA-354
>                 URL: https://issues.apache.org/jira/browse/GORA-354
>             Project: Apache Gora
>          Issue Type: Improvement
>          Components: gora-core
>    Affects Versions: 0.5
>            Reporter: Lewis John McGibbney
>            Assignee: Tyler Palsulich
>            Priority: Critical
>             Fix For: 0.5
>         Attachments: GORA-354.palsulich.070914.patch, GORA-354.palsulich.071414.full.patch,
GORA-354.palsulich.071514.full.patch, GORA-354.unit-test.patch
> Right now it appears that the reading of key's and value's from DataStoreFactory#findProperty
is a process which does not lowercase keys or values.
> This can result in undesired behavhiour meaning that configuration properties are not
used properly @Runtime.
> The fix should be a lowercasing of all properties so that they can be stored within and
read from the call to System properties.

This message was sent by Atlassian JIRA

View raw message