gora-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alfonso Nishikawa (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (GORA-357) Maven Surefire testFailureIgnore is true
Date Mon, 25 Aug 2014 19:58:58 GMT

    [ https://issues.apache.org/jira/browse/GORA-357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14100530#comment-14100530
] 

Alfonso Nishikawa edited comment on GORA-357 at 8/25/14 7:57 PM:
-----------------------------------------------------------------

I think we should question why, for example {{TestDataFileAvroStoreMapReduce}} fails (this
is something happened to me and I hope I will have time to take a look at it).

I am against the profiles things for this because:

# Long running tests are those related to execution in a hadoop environment or with a real
DB backend. Personally I prefer to use [failsafe plugin|http://maven.apache.org/surefire/maven-failsafe-plugin/]
for integration tests, so that heavy tests only happens when you execute {{mvn verify}} ({{package}}
will only execute the unit tests).
# In my oppinion, if you want to compile Gora interested only in some submodules, you should
modify the {{pom.xml}} and leave enabled only the modules you are interested in.
# If you want to pass only one tests or a set of tests you can do [[{{mvn test -Dtest=...}}|http://maven.apache.org/surefire/maven-surefire-plugin/examples/single-test.html]].
# If you want only to pass tests from a submodule you can do {{mvn test \-pl <submodule>}}
(or {{--projects}}).

At the same time, _if_ (I hope not) profiles are used for this purpose, then {{mvn test}}
should pass all tests, while {{mvn test -Pprofile}} pass a subset. Sadly, the point of view
must be the developer's one: {{mvn test}} executes the tests.

It's just my oppinion! :)



was (Author: alfonso.nishikawa):
I think we should question why, for example {{TestDataFileAvroStoreMapReduce}} fails (this
is something happened to me and I hope I will have time to take a look at it).

I am against the profiles things for this because:

# Long running tests are those related to execution in a hadoop environment or with a real
DB backend. Personally I prefer to use [failsafe plugin|http://maven.apache.org/surefire/maven-failsafe-plugin/]
for integration tests, so that heavy tests only happens when you execute {{mvn verify}} ({{package}}
will only execute the unit tests).
# In my oppinion, if you want to compile Gora interested only in some submodules, you should
modify the {{pom.xml}} and leave enabled only the modules you are interested in.
# If you want to pass only one tests or a set of tests you can do [[{{mvn test -Dtest=...}}|http://maven.apache.org/surefire/maven-surefire-plugin/examples/single-test.html]].
# If you want only to pass tests from a submodule you can do {{mvn test \-pl <submodule>}}
(or {{--project}}).

At the same time, _if_ (I hope not) profiles are used for this purpose, then {{mvn test}}
should pass all tests, while {{mvn test -Pprofile}} pass a subset. Sadly, the point of view
must be the developer's one: {{mvn test}} executes the tests.

It's just my oppinion! :)


> Maven Surefire testFailureIgnore is true
> ----------------------------------------
>
>                 Key: GORA-357
>                 URL: https://issues.apache.org/jira/browse/GORA-357
>             Project: Apache Gora
>          Issue Type: Bug
>          Components: build process
>            Reporter: Tyler Palsulich
>            Priority: Minor
>         Attachments: GORA-357.palsulich.071614.patch
>
>
> The root pom.xml file has the following line: {{<testFailureIgnore>true</testFailureIgnore>}}.
I've noticed that some unit tests fail on a clean install (e.g. gora.avro.mapreduce.TestDataFileAvroStoreMapReduce).
Is this to be expected?



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message