gora-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GORA-410) Change logging behavior to pass exception object to LOG methods
Date Sun, 22 Feb 2015 22:11:11 GMT

    [ https://issues.apache.org/jira/browse/GORA-410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14332396#comment-14332396
] 

Hudson commented on GORA-410:
-----------------------------

SUCCESS: Integrated in gora-trunk #1418 (See [https://builds.apache.org/job/gora-trunk/1418/])
GORA-410 Change logging behavior to pass exception object to LOG methods (lewis.j.mcgibbney:
rev 65d6c7ac29d2cc041d067e5e7f0857936a7529d7)
* gora-core/src/main/java/org/apache/gora/avro/store/AvroStore.java
* gora-core/src/main/java/org/apache/gora/store/impl/DataStoreBase.java
* gora-dynamodb/src/main/java/org/apache/gora/dynamodb/store/DynamoDBStore.java
* CHANGES.txt
* gora-solr/src/main/java/org/apache/gora/solr/store/SolrStore.java
* gora-core/src/main/java/org/apache/gora/avro/store/DataFileAvroStore.java
* gora-cassandra/src/main/java/org/apache/gora/cassandra/store/CassandraStore.java
* gora-hbase/src/main/java/org/apache/gora/hbase/store/HBaseStore.java
* gora-core/src/main/java/org/apache/gora/store/impl/FileBackedDataStoreBase.java


> Change logging behavior to pass exception object to LOG methods
> ---------------------------------------------------------------
>
>                 Key: GORA-410
>                 URL: https://issues.apache.org/jira/browse/GORA-410
>             Project: Apache Gora
>          Issue Type: Improvement
>            Reporter: Gerhard Gossen
>            Assignee: Gerhard Gossen
>             Fix For: 0.7
>
>         Attachments: exception_logging.patch
>
>
> Throughout the codebase, exceptions are reported by logging {{e.getStackTrace().toString()}}.
As {{getStackTrace}} returns an array and Java's array {{.toString}} method just returns the
object ID, this means that the stack traces are effectively lost. Instead the exception should
be passed to the logger in its original form as the second argument, SLF4J does the right
thing with the stack trace.
> This problem was tackled in GORA-230 for AccumuloStore. The attached patch corrects all
instances of the problem in the current trunk.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message