gora-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Furkan KAMACI <furkankam...@gmail.com>
Subject Cleaning Up Gora Source Code
Date Fri, 04 Sep 2015 13:34:41 GMT
Hi All,

As you know that I'm continuing to contribute Gora after my GSoC period.
I've started with bugs and cleaning up Gora source code. I've opened some
issues and applied patches for that purpose and still doing that.

My question is about: I realized that some method parameters are not used
within that methods.

These are:

*fieldName* at
https://github.com/apache/gora/blob/master/gora-cassandra/src/main/java/org/apache/gora/cassandra/query/CassandraSuperColumn.java#L162

*dataStore* at:
https://github.com/apache/gora/blob/master/gora-core/src/test/java/org/apache/gora/store/DataStoreTestUtil.java#L95

*dataStore* at:
https://github.com/apache/gora/blob/master/gora-core/src/test/java/org/apache/gora/store/DataStoreTestUtil.java#L106

*dataStore* at:
https://github.com/apache/gora/blob/master/gora-core/src/test/java/org/apache/gora/store/DataStoreTestUtil.java#L116

*context* at:
https://github.com/apache/gora/blob/master/gora-core/src/main/java/org/apache/gora/mapreduce/GoraInputFormat.java#L68

*dataStore* at:
https://github.com/apache/gora/blob/master/gora-core/src/main/java/org/apache/gora/mapreduce/GoraInputFormat.java#L150

*schema* at:
https://github.com/apache/gora/blob/master/gora-core/src/main/java/org/apache/gora/util/IOUtils.java#L156

*schema* at:
https://github.com/apache/gora/blob/master/gora-core/src/main/java/org/apache/gora/util/IOUtils.java#L168

*schema* at:
https://github.com/apache/gora/blob/master/gora-core/src/main/java/org/apache/gora/util/IOUtils.java#L265

*schema* at:
https://github.com/apache/gora/blob/master/gora-core/src/main/java/org/apache/gora/util/IOUtils.java#L275

*schema* at:
https://github.com/apache/gora/blob/master/gora-core/src/main/java/org/apache/gora/util/IOUtils.java#L285

*docNameFromMapping* at:
https://github.com/apache/gora/blob/master/gora-mongodb/src/main/java/org/apache/gora/mongodb/store/MongoMapping.java#L165

If there are not special purposes for them I would like to *refactor* that
methods and create a pull request.

Kind Regards,
Furkan KAMACI

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message