gora-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "emopers (JIRA)" <j...@apache.org>
Subject [jira] [Created] (GORA-467) Flushing DataOutputStream before calling toByteArray on the underlying ByteArrayOutputStream
Date Thu, 04 Feb 2016 07:22:39 GMT
emopers created GORA-467:
----------------------------

             Summary: Flushing DataOutputStream before calling toByteArray on the underlying
ByteArrayOutputStream
                 Key: GORA-467
                 URL: https://issues.apache.org/jira/browse/GORA-467
             Project: Apache Gora
          Issue Type: Bug
          Components: gora-core
            Reporter: emopers
            Priority: Minor


In ./gora-core/src/test/java/org/apache/gora/util/TestWritableUtils.java
{code}
ByteArrayOutputStream bos = new ByteArrayOutputStream();
    DataOutput out = new DataOutputStream(bos);
    WritableUtils.writeProperties(out, props);
    
    DataInput in = new DataInputStream(new ByteArrayInputStream(bos.toByteArray()));
{code}
When a DataOutputStream instance wraps an underlying ByteArrayOutputStream instance,
it is recommended to flush or close the DataOutputStream before invoking the underlying instances's
toByteArray(). Also, it is a good practice to call flush/close explicitly as mentioned for
example at http://stackoverflow.com/questions/2984538/how-to-use-bytearrayoutputstream-and-dataoutputstream-simultaneously-java.
The patch adds a flush method before calling toByteArray().



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message