gora-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From lewismc <...@git.apache.org>
Subject [GitHub] gora pull request: GORA-465 remove deprecated logic
Date Mon, 23 May 2016 01:06:02 GMT
Github user lewismc commented on a diff in the pull request:

    https://github.com/apache/gora/pull/67#discussion_r64160518
  
    --- Diff: gora-hbase/src/main/java/org/apache/gora/hbase/store/HBaseStore.java ---
    @@ -116,18 +114,8 @@ public void initialize(Class<K> keyClass, Class<T> persistentClass,
           mapping = readMapping(getConf().get(PARSE_MAPPING_FILE_KEY, DEFAULT_MAPPING_FILE));
           filterUtil = new HBaseFilterUtil<>(this.conf);
         } catch (FileNotFoundException ex) {
    -      try {
    -        mapping = readMapping(getConf().get(PARSE_MAPPING_FILE_KEY, DEPRECATED_MAPPING_FILE));
    -        LOG.warn(DEPRECATED_MAPPING_FILE + " is deprecated, please rename the file to
"
    -            + DEFAULT_MAPPING_FILE);
    -      } catch (FileNotFoundException ex1) {
    -          LOG.error(ex1.getMessage(), ex1);
    -          //throw (ex1); //throw the original exception
    -      } catch (Exception ex1) {
    -        LOG.warn(DEPRECATED_MAPPING_FILE + " is deprecated, please rename the file to
"
    -            + DEFAULT_MAPPING_FILE);
    -        throw new RuntimeException(ex1);
    -      } 
    +      LOG.error(DEFAULT_MAPPING_FILE + " is not found, please check the file.");
    --- End diff --
    
    Can you please use the paramaterized slf4j logging notation here? e.g. 
    ```
     +      LOG.error("{}  is not found, please check the file.", DEFAULT_MAPPING_FILE); 
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message