gora-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jaechang Nam (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (GORA-499) Potential NPE issue
Date Sat, 28 Jan 2017 06:49:24 GMT

     [ https://issues.apache.org/jira/browse/GORA-499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Jaechang Nam updated GORA-499:
------------------------------
    Description: 
Dear Gora developers

In recent git repository, I've found the following lines in gora-cassandra/src/main/java/org/apache/gora/cassandra/store/CassandraClient.java.

{code:java}
String opConsisLvl = (readOpConsLvl!=null || !readOpConsLvl.isEmpty())?readOpConsLvl:DEFAULT_HECTOR_CONSIS_LEVEL;
      ccl.setDefaultReadConsistencyLevel(HConsistencyLevel.valueOf(opConsisLvl));
      LOG.debug("Hector read consistency configured to '" + opConsisLvl + "'.");
      opConsisLvl = (writeOpConsLvl!=null || !writeOpConsLvl.isEmpty())?writeOpConsLvl:DEFAULT_HECTOR_CONSIS_LEVEL;
{code}

It seems, if readOpConsLvl or writeOpConsLvl is null, there could be NullPointerException
as the comparison operator is "||" rather using "&&". I have no idea if this is an
actual bug but just reporting. Thanks!


  was:
Dear Gora developers

In recent got repositiry, I've found the following lines in gora-cassandra/src/main/java/org/apache/gora/cassandra/store/CassandraClient.java.

<pre>
String opConsisLvl = (readOpConsLvl!=null || !readOpConsLvl.isEmpty())?readOpConsLvl:DEFAULT_HECTOR_CONSIS_LEVEL;
      ccl.setDefaultReadConsistencyLevel(HConsistencyLevel.valueOf(opConsisLvl));
      LOG.debug("Hector read consistency configured to '" + opConsisLvl + "'.");
      opConsisLvl = (writeOpConsLvl!=null || !writeOpConsLvl.isEmpty())?writeOpConsLvl:DEFAULT_HECTOR_CONSIS_LEVEL;
</pre>

It seems readOpConsLvl or writeOpConsLvl is null, there could be NullPointerException as the
comparison operator is "||" rather using "&&". I have no idea if this is an actual
bug but just reporting. Thanks!



> Potential NPE issue
> -------------------
>
>                 Key: GORA-499
>                 URL: https://issues.apache.org/jira/browse/GORA-499
>             Project: Apache Gora
>          Issue Type: Bug
>            Reporter: Jaechang Nam
>            Priority: Minor
>
> Dear Gora developers
> In recent git repository, I've found the following lines in gora-cassandra/src/main/java/org/apache/gora/cassandra/store/CassandraClient.java.
> {code:java}
> String opConsisLvl = (readOpConsLvl!=null || !readOpConsLvl.isEmpty())?readOpConsLvl:DEFAULT_HECTOR_CONSIS_LEVEL;
>       ccl.setDefaultReadConsistencyLevel(HConsistencyLevel.valueOf(opConsisLvl));
>       LOG.debug("Hector read consistency configured to '" + opConsisLvl + "'.");
>       opConsisLvl = (writeOpConsLvl!=null || !writeOpConsLvl.isEmpty())?writeOpConsLvl:DEFAULT_HECTOR_CONSIS_LEVEL;
> {code}
> It seems, if readOpConsLvl or writeOpConsLvl is null, there could be NullPointerException
as the comparison operator is "||" rather using "&&". I have no idea if this is an
actual bug but just reporting. Thanks!



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message