gora-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From lewismc <...@git.apache.org>
Subject [GitHub] gora issue #97: Switched Accumulo Dependency to 1.7.1 and ported AccumuloSto...
Date Wed, 22 Feb 2017 15:18:16 GMT
Github user lewismc commented on the issue:

    https://github.com/apache/gora/pull/97
  
    Regarding the formatting... yeah I agree. That's my fault, I thought
    AccumuloStore was already formatted 2 space indents.
    We should probably use the maven formatting plugin with out code template
    in a subsequent issue.
    
    On Wed, Feb 22, 2017 at 4:53 AM Renato Marroquin <notifications@github.com>
    wrote:
    
    > @lewismc <https://github.com/lewismc> regarding the 2space vs 4space, the
    > only issue with this is that now the whole AccumuloStore looks like if it
    > was modified, didn't we had a style check on maven at some point? maybe we
    > should have a JIRA to just make the whole code standard and keep the
    > changes of this PR only addressing the ones that it's supposed to
    >
    > —
    > You are receiving this because you were mentioned.
    >
    >
    > Reply to this email directly, view it on GitHub
    > <https://github.com/apache/gora/pull/97#issuecomment-281661168>, or mute
    > the thread
    > <https://github.com/notifications/unsubscribe-auth/ABHJl1EHr9v5PUkq3mjn0w2XA8nIqeg8ks5rfC_kgaJpZM4MEAkC>
    > .
    >
    -- 
    
    *Lewis*
    Dr. Lewis J. McGibbney Ph.D, B.Sc
    Director, MCMA Associates
    Phone: +1(626)498-3090
    Skype: lewis.john.mcgibbney
    Email: lewis.mcgibbney@gmail.com



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message