gora-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GORA-472) All gora-hbase tests to be comparative
Date Thu, 23 Feb 2017 16:49:44 GMT

    [ https://issues.apache.org/jira/browse/GORA-472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880821#comment-15880821

ASF GitHub Bot commented on GORA-472:

Github user lewismc commented on the issue:

    Hi @cloudysunny14 OK great work. The only test failing is now ```TestHBaseStore#testDeleteByQuery```
which is a big step forward. I must note however that the tests seemed to take a very long
time. We can deal with this later on I suppose.
    Are you suggesting that the PR associated with this issue fixes TestHBaseStore#testDeleteByQuery

> All gora-hbase tests to be comparative
> --------------------------------------
>                 Key: GORA-472
>                 URL: https://issues.apache.org/jira/browse/GORA-472
>             Project: Apache Gora
>          Issue Type: Bug
>          Components: gora-hbase, testing
>            Reporter: Lewis John McGibbney
>             Fix For: 0.8
> I am starting to get a tad sad with seeing the following in sure fire reports
> {code}
> testDeleteByQueryFields(org.apache.gora.hbase.store.TestHBaseStore)  Time elapsed: 13.287
sec  <<< FAILURE!
> java.lang.AssertionError
> 	at org.junit.Assert.fail(Assert.java:92)
> 	at org.junit.Assert.assertTrue(Assert.java:43)
> 	at org.junit.Assert.assertTrue(Assert.java:54)
> 	at org.apache.gora.store.DataStoreTestUtil.assertWebPage(DataStoreTestUtil.java:740)
> {code}
> We need to start using the comparative aspect of the JUnit API, this enables us to compare
the results of what we got and what we expected. 

This message was sent by Atlassian JIRA

View raw message