gora-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From lewismc <...@git.apache.org>
Subject [GitHub] gora issue #103: GORA-394 Resolve erroneous error logging in reading HBase m...
Date Sat, 27 May 2017 07:19:27 GMT
Github user lewismc commented on the issue:

    https://github.com/apache/gora/pull/103
  
    @alfonsonishikawa can you check this out? I am not using HBase at this moment... if you
cannot I will pull the source for HBase and try it out. 
    
    @nishadi I've looked at the PR and it looks good to me, however I wonder if there is a
small test we could include for the [HBaseStore#readMapping](https://github.com/apache/gora/blob/master/gora-hbase/src/main/java/org/apache/gora/hbase/store/HBaseStore.java#L730)
which would allow us to verify the behavior? Well annotated unit tests, specifically on individual
datastores are very useful for datastore-specific behaviour. 
    Thank you for the PR, this is great.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message