gora-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GORA-394) Erroneous 'Error: KeyClass in gora-hbase-mapping is not the same as the one in the databean.' log when reading HBase mapping
Date Sat, 27 May 2017 07:05:04 GMT

    [ https://issues.apache.org/jira/browse/GORA-394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16027308#comment-16027308
] 

ASF GitHub Bot commented on GORA-394:
-------------------------------------

GitHub user nishadi opened a pull request:

    https://github.com/apache/gora/pull/103

    GORA-394 Resolve erroneous error logging in reading HBase mapping file

    This PR resolves erroneous error logging in reading HBase mapping file as stated in the
issue

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/nishadi/gora issue-394

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/gora/pull/103.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #103
    
----
commit 7c0e34eb942ae2fb990795c6ffce1632edfdccac
Author: nishadi <ndimeshi@gmail.com>
Date:   2017-05-27T06:59:35Z

    Resolve errorneous error logging in reading HBase mapping file

----


> Erroneous 'Error: KeyClass in gora-hbase-mapping is not the same as the one in the databean.'
log when reading HBase mapping
> ----------------------------------------------------------------------------------------------------------------------------
>
>                 Key: GORA-394
>                 URL: https://issues.apache.org/jira/browse/GORA-394
>             Project: Apache Gora
>          Issue Type: Bug
>          Components: gora-hbase
>    Affects Versions: 0.4, 0.5
>            Reporter: Alfonso Nishikawa
>            Priority: Trivial
>              Labels: logging, mapping
>             Fix For: 0.8
>
>
> When reading the {{<class>}} mapping in gora-hbase in [HBaseStore|https://github.com/apache/gora/blob/master/gora-hbase/src/main/java/org/apache/gora/hbase/store/HBaseStore.java#L756],
it keeps iterating all {{<class>}} tags until finds the one for the datastore generic
parameters (key and value matches).
> For that, [this {{else}} block|https://github.com/apache/gora/blob/master/gora-hbase/src/main/java/org/apache/gora/hbase/store/HBaseStore.java#L790]
is erroneous because we expect the {{if}} to be true only once and false serveral times, depending
the number of entities defined in the mapping file.
> The error log "KeyClass in gora-hbase-mapping is not the same as the one in the databean."
must only be shown after finishing traversing all {{<class>}} elements and finding no
match.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message