gora-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GORA-394) Erroneous 'Error: KeyClass in gora-hbase-mapping is not the same as the one in the databean.' log when reading HBase mapping
Date Sun, 28 May 2017 08:43:04 GMT

    [ https://issues.apache.org/jira/browse/GORA-394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16027744#comment-16027744
] 

ASF GitHub Bot commented on GORA-394:
-------------------------------------

Github user alfonsonishikawa commented on the issue:

    https://github.com/apache/gora/pull/103
  
    Hi!
    
    I don't find necessary to have tests on this issue. The reason is that the issue is about
a wrong placed logging -the need to move it out of the `for`-, so I don't find anything to
test and the fix looks perfect.
    
    +1 to merge to master, since it solves https://issues.apache.org/jira/browse/GORA-394
perfectly.
    
    I suggest, as a later improvement in other issue, to discuss if it is suitable to throw
an exception after logging (fail fast when the configuration is wrong) - and in this case
a test will be needed, of couse :) -
    
    @nishadi, thanks for the fix!
    



> Erroneous 'Error: KeyClass in gora-hbase-mapping is not the same as the one in the databean.'
log when reading HBase mapping
> ----------------------------------------------------------------------------------------------------------------------------
>
>                 Key: GORA-394
>                 URL: https://issues.apache.org/jira/browse/GORA-394
>             Project: Apache Gora
>          Issue Type: Bug
>          Components: gora-hbase
>    Affects Versions: 0.4, 0.5
>            Reporter: Alfonso Nishikawa
>            Assignee: Nishadi Kirielle
>            Priority: Trivial
>              Labels: logging, mapping
>             Fix For: 0.8
>
>
> When reading the {{<class>}} mapping in gora-hbase in [HBaseStore|https://github.com/apache/gora/blob/master/gora-hbase/src/main/java/org/apache/gora/hbase/store/HBaseStore.java#L756],
it keeps iterating all {{<class>}} tags until finds the one for the datastore generic
parameters (key and value matches).
> For that, [this {{else}} block|https://github.com/apache/gora/blob/master/gora-hbase/src/main/java/org/apache/gora/hbase/store/HBaseStore.java#L790]
is erroneous because we expect the {{if}} to be true only once and false serveral times, depending
the number of entities defined in the mapping file.
> The error log "KeyClass in gora-hbase-mapping is not the same as the one in the databean."
must only be shown after finishing traversing all {{<class>}} elements and finding no
match.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message