gora-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lewis John McGibbney (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GORA-255) Remove deprecated methods from DataStoreTestBase
Date Fri, 02 Jun 2017 05:24:05 GMT

    [ https://issues.apache.org/jira/browse/GORA-255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16034157#comment-16034157
] 

Lewis John McGibbney commented on GORA-255:
-------------------------------------------

If I were you [~nishadi] I would try implementing the MemStoreTestDriver as suggested by [~alfonso.nishikawa],
I say this simply because use of MemStore is very limited to unit testing and some mock implementations.
As you know, it is really only a simple in-memory Map and not used widely. Please don't spend
too much time on this issue e.g. don't think too deeply in to it. I suggest that you just
implement MemStoreTestDriver then remove the @ Deprecated methods. Thank you again.

> Remove deprecated methods from DataStoreTestBase 
> -------------------------------------------------
>
>                 Key: GORA-255
>                 URL: https://issues.apache.org/jira/browse/GORA-255
>             Project: Apache Gora
>          Issue Type: Improvement
>          Components: testing
>    Affects Versions: 0.4
>            Reporter: Apostolos Giannakidis
>            Assignee: Apostolos Giannakidis
>            Priority: Minor
>              Labels: test
>             Fix For: 0.8
>
>
> The abstract class DataStoreTestBase contains 2 deprecated methods:
> DataStore<String, Employee> createEmployeeDataStore()
> DataStore<String, WebPage> createWebPageDataStore()
> These methods were useful in the past but they seem not to be useful now.
> I believe that they should be removed from the abstract class DataStoreTestBase. Their
concrete implementations from the subclasses that extend the DataStoreTestBase should also
be removed.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message