gora-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alfonso Nishikawa (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GORA-255) Remove deprecated methods from DataStoreTestBase
Date Mon, 05 Jun 2017 21:15:04 GMT

    [ https://issues.apache.org/jira/browse/GORA-255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16037606#comment-16037606

Alfonso Nishikawa commented on GORA-255:

Wow, I have been very busy (I am attending a Cloudera course) and this is already closed!
I am surprised that all test pass with that mock implementation.

Thanks and good job!

And sorry for not reading before :S

> Remove deprecated methods from DataStoreTestBase 
> -------------------------------------------------
>                 Key: GORA-255
>                 URL: https://issues.apache.org/jira/browse/GORA-255
>             Project: Apache Gora
>          Issue Type: Improvement
>          Components: testing
>    Affects Versions: 0.4
>            Reporter: Apostolos Giannakidis
>            Assignee: Nishadi Kirielle
>            Priority: Minor
>              Labels: test
>             Fix For: 0.8
> The abstract class DataStoreTestBase contains 2 deprecated methods:
> DataStore<String, Employee> createEmployeeDataStore()
> DataStore<String, WebPage> createWebPageDataStore()
> These methods were useful in the past but they seem not to be useful now.
> I believe that they should be removed from the abstract class DataStoreTestBase. Their
concrete implementations from the subclasses that extend the DataStoreTestBase should also
be removed.

This message was sent by Atlassian JIRA

View raw message