gora-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GORA-512) Fail at the time of error logging if KeyClass in gora-hbase-mapping is not the same as the one in the data bean
Date Mon, 12 Jun 2017 19:05:00 GMT

    [ https://issues.apache.org/jira/browse/GORA-512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16046952#comment-16046952
] 

ASF GitHub Bot commented on GORA-512:
-------------------------------------

Github user renato2099 commented on the issue:

    https://github.com/apache/gora/pull/109
  
    this looks to me +1


> Fail at the time of error logging if KeyClass in gora-hbase-mapping is not the same as
the one in the data bean
> ---------------------------------------------------------------------------------------------------------------
>
>                 Key: GORA-512
>                 URL: https://issues.apache.org/jira/browse/GORA-512
>             Project: Apache Gora
>          Issue Type: Improvement
>          Components: gora-hbase
>            Reporter: Nishadi Kirielle
>            Assignee: Nishadi Kirielle
>            Priority: Minor
>             Fix For: 0.8
>
>
> In the current implementation, when reading the HBase mapping file, if the HBase mapping
file does not have a matching key class and name to the data bean, it only logs that information.[1]
It does not fail at the time of detecting it. It fails only at the time of building the mapper
[2] when it detects the table name is null. It will be better if it can fail at the time of
detecting that mapping file is missing the corresponding class. 
> [1]. https://github.com/apache/gora/blob/master/gora-hbase/src/main/java/org/apache/gora/hbase/store/HBaseStore.java#L797
> [2]. https://github.com/apache/gora/blob/master/gora-hbase/src/main/java/org/apache/gora/hbase/store/HBaseStore.java#L815



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message