gora-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GORA-526) Potential null dereference in AvroSerializer#analyzePersistent
Date Fri, 22 Sep 2017 05:07:00 GMT

    [ https://issues.apache.org/jira/browse/GORA-526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16175925#comment-16175925
] 

ASF GitHub Bot commented on GORA-526:
-------------------------------------

Github user madhawa-gunasekara commented on the issue:

    https://github.com/apache/gora/pull/123
  
    Hi @lewismc 
    Please find the JIRA issue for this. 
    [1] https://issues.apache.org/jira/browse/GORA-526


> Potential null dereference in AvroSerializer#analyzePersistent
> --------------------------------------------------------------
>
>                 Key: GORA-526
>                 URL: https://issues.apache.org/jira/browse/GORA-526
>             Project: Apache Gora
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Madhawa Gunasekara
>            Priority: Minor
>             Fix For: 0.9
>
>
> In ctor:
> {code}
>     if (PersistentBase.class.isAssignableFrom(dataStore.getPersistentClass())) {
>       persistentSchema = ((PersistentBase) dataStore.getBeanFactory().getCachedPersistent()).getSchema();
>     } else {
>       persistentSchema = null;
> {code}
> In updateByQuery, persistentSchema is passed to CassandraQueryFactory.getUpdateByQueryForAvro()
which dereferences the schema without checking:
> {code}
>   public boolean updateByQuery(Query query) {
>     List<Object> objectArrayList = new ArrayList<>();
>     String cqlQuery = CassandraQueryFactory.getUpdateByQueryForAvro(mapping, query, objectArrayList,
persistentSchema);
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message