gora-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From renato2099 <...@git.apache.org>
Subject [GitHub] gora pull request #131: GORA-266 Lucene datastore for Gora
Date Thu, 15 Mar 2018 15:52:51 GMT
Github user renato2099 commented on a diff in the pull request:

    https://github.com/apache/gora/pull/131#discussion_r174717006
  
    --- Diff: gora-core/src/main/java/org/apache/gora/util/IOUtils.java ---
    @@ -611,8 +609,7 @@ public static void writeStringArray(DataOutput out, String[] arr)
         String classKey = dataKey + "._class";
         String className = conf.get(classKey);
         try {
    -      T obj = (T) DefaultStringifier.load(conf, dataKey, ClassLoadingUtils.loadClass(className));
    -      return obj;
    +      return (T) DefaultStringifier.load(conf, dataKey, ClassLoadingUtils.loadClass(className));
         } catch (Exception ex) {
    --- End diff --
    
    This should throw a more specific exception. DefaultStringifier.load() throws an IOException.
    And actually this should be aligned to the latest discussion with @alfonsonishikawa  and
@nishadi about wrapping exceptions into GoraExceptions. What is your input on this one guys?


---

Mime
View raw message