gora-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GORA-266) Lucene datastore for Gora
Date Thu, 15 Mar 2018 15:53:01 GMT

    [ https://issues.apache.org/jira/browse/GORA-266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16400600#comment-16400600
] 

ASF GitHub Bot commented on GORA-266:
-------------------------------------

Github user renato2099 commented on a diff in the pull request:

    https://github.com/apache/gora/pull/131#discussion_r174717006
  
    --- Diff: gora-core/src/main/java/org/apache/gora/util/IOUtils.java ---
    @@ -611,8 +609,7 @@ public static void writeStringArray(DataOutput out, String[] arr)
         String classKey = dataKey + "._class";
         String className = conf.get(classKey);
         try {
    -      T obj = (T) DefaultStringifier.load(conf, dataKey, ClassLoadingUtils.loadClass(className));
    -      return obj;
    +      return (T) DefaultStringifier.load(conf, dataKey, ClassLoadingUtils.loadClass(className));
         } catch (Exception ex) {
    --- End diff --
    
    This should throw a more specific exception. DefaultStringifier.load() throws an IOException.
    And actually this should be aligned to the latest discussion with @alfonsonishikawa  and
@nishadi about wrapping exceptions into GoraExceptions. What is your input on this one guys?


> Lucene datastore for Gora
> -------------------------
>
>                 Key: GORA-266
>                 URL: https://issues.apache.org/jira/browse/GORA-266
>             Project: Apache Gora
>          Issue Type: New Feature
>          Components: gora-lucene
>            Reporter: Lewis John McGibbney
>            Assignee: Lewis John McGibbney
>            Priority: Minor
>              Labels: features
>             Fix For: 0.9
>
>         Attachments: GORA-266.patch
>
>
> Sometimes we don't need to set up, administer, maintain and configure a running solr
server(s).
> Sometime we just want to write to Lucene index files and read directly from them. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message