gora-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Carlos Muñoz (JIRA) <j...@apache.org>
Subject [jira] [Commented] (GORA-444) Add #size() to Result API
Date Thu, 22 Mar 2018 06:22:00 GMT

    [ https://issues.apache.org/jira/browse/GORA-444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16409113#comment-16409113

Carlos Muñoz commented on GORA-444:

Hi [~lewismc] , [~renato2099]

Thanks for your help.

I have been working on my fork and I would highly appreciate if you can check the changes
I have done.

1. I added the size() function into the 'easy' backends ([Commit 1|https://github.com/carlosrmng/gora/commit/76cc89cddd2cbda42518de8e304e92e3f341a744])

2. I used the limit attribute of Query to set the batch size in Accumulo, Avro and HBase,
so 'this.limit' could be used for implementing size() on those backends. ([Commit 2|https://github.com/carlosrmng/gora/commit/0ee48ab3d96445a280852a1fd04206efb883baa9])

Also, I was wondering where should I add a test for this new function? I was thinking I could
add a test in 'DataStoreTestBase', so it could be reused for all the backends.

> Add #size() to Result API
> -------------------------
>                 Key: GORA-444
>                 URL: https://issues.apache.org/jira/browse/GORA-444
>             Project: Apache Gora
>          Issue Type: New Feature
>          Components: gora-core
>            Reporter: Lewis John McGibbney
>            Priority: Minor
>             Fix For: 0.9
> Right now we iterate through results by doing 
> {code}
> while (results.next()) {
>    ...
> }
> {code}
> It is a pain to always require a counter of sorts and would be much more intuitive to
provide a simple #size() method.

This message was sent by Atlassian JIRA

View raw message