gora-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GORA-444) Add #size() to Result API
Date Fri, 23 Mar 2018 05:31:00 GMT

    [ https://issues.apache.org/jira/browse/GORA-444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16410824#comment-16410824
] 

ASF GitHub Bot commented on GORA-444:
-------------------------------------

GitHub user carlosrmng opened a pull request:

    https://github.com/apache/gora/pull/132

    Gora-444 : Add #size() to Result API

    This PR adds  #size() to Result API, it implements size() for existing backends. The complete
disscusion can be found in [GORA-444](https://issues.apache.org/jira/browse/GORA-444).
    
    Some issues with this PR:
    -new tests are need.
    -Backends: Accumulo, Avro, HBase, don't support size() functions, so an approach using
batchSize was used instead.
    
    Code review welcome, thanks

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/carlosrmng/gora GORA-444

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/gora/pull/132.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #132
    
----
commit 76cc89cddd2cbda42518de8e304e92e3f341a744
Author: Carlos Muñoz <carlosrmng@...>
Date:   2018-03-22T05:06:56Z

    Add #size() to Result API: Aerospike, Cassandra, CouchDB, DynamoDB, MongoDB, OrientDB,
JCache, Solr, Mock, Mem.

commit 0ee48ab3d96445a280852a1fd04206efb883baa9
Author: Carlos Muñoz <carlosrmng@...>
Date:   2018-03-22T05:59:02Z

    Add #size() to Result API: Accumulo, Avro, HBase
    Set batch size using query.limit

----


> Add #size() to Result API
> -------------------------
>
>                 Key: GORA-444
>                 URL: https://issues.apache.org/jira/browse/GORA-444
>             Project: Apache Gora
>          Issue Type: New Feature
>          Components: gora-core
>            Reporter: Lewis John McGibbney
>            Priority: Minor
>             Fix For: 0.9
>
>
> Right now we iterate through results by doing 
> {code}
> while (results.next()) {
>    ...
> }
> {code}
> It is a pain to always require a counter of sorts and would be much more intuitive to
provide a simple #size() method.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message