From dev-return-10658-apmail-gora-dev-archive=gora.apache.org@gora.apache.org  Sat Jul 14 22:07:52 2018
Return-Path: <dev-return-10658-apmail-gora-dev-archive=gora.apache.org@gora.apache.org>
X-Original-To: apmail-gora-dev-archive@www.apache.org
Delivered-To: apmail-gora-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 4A46A186FF
	for <apmail-gora-dev-archive@www.apache.org>; Sat, 14 Jul 2018 22:07:52 +0000 (UTC)
Received: (qmail 66331 invoked by uid 500); 14 Jul 2018 22:07:52 -0000
Delivered-To: apmail-gora-dev-archive@gora.apache.org
Received: (qmail 66267 invoked by uid 500); 14 Jul 2018 22:07:52 -0000
Mailing-List: contact dev-help@gora.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@gora.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@gora.apache.org>
List-Post: <mailto:dev@gora.apache.org>
List-Id: <dev.gora.apache.org>
Reply-To: dev@gora.apache.org
Delivered-To: mailing list dev@gora.apache.org
Received: (qmail 65873 invoked by uid 99); 14 Jul 2018 22:07:51 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 14 Jul 2018 22:07:51 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id 8CC7EE0614; Sat, 14 Jul 2018 22:07:50 +0000 (UTC)
From: lewismc <git@git.apache.org>
To: dev@gora.apache.org
Reply-To: dev@gora.apache.org
References: <git-pr-134-gora@git.apache.org>
In-Reply-To: <git-pr-134-gora@git.apache.org>
Subject: [GitHub] gora pull request #134: GORA-535 Add a data store for Apache Ignite
Content-Type: text/plain
Message-Id: <20180714220750.8CC7EE0614@git1-us-west.apache.org>
Date: Sat, 14 Jul 2018 22:07:50 +0000 (UTC)

Github user lewismc commented on a diff in the pull request:

    https://github.com/apache/gora/pull/134#discussion_r202523513
  
    --- Diff: gora-ignite/pom.xml ---
    @@ -0,0 +1,182 @@
    +<?xml version="1.0" encoding="UTF-8"?>
    +<!--
    +  Licensed to the Apache Software Foundation (ASF) under one
    +  or more contributor license agreements.  See the NOTICE file
    +  distributed with this work for additional information
    +  regarding copyright ownership.  The ASF licenses this file
    +  to you under the Apache License, Version 2.0 (the
    +  "License"); you may not use this file except in compliance
    +  with the License.  You may obtain a copy of the License at
    +
    +    http://www.apache.org/licenses/LICENSE-2.0
    +
    +  Unless required by applicable law or agreed to in writing,
    +  software distributed under the License is distributed on an
    +  "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    +  KIND, either express or implied.  See the License for the
    +  specific language governing permissions and limitations
    +  under the License.
    +-->
    +<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
    +  <modelVersion>4.0.0</modelVersion>
    +
    +  <parent>
    +    <groupId>org.apache.gora</groupId>
    +    <artifactId>gora</artifactId>
    +    <version>0.9-SNAPSHOT</version>
    +    <relativePath>../</relativePath>
    +  </parent>
    +  <artifactId>gora-ignite</artifactId>
    +  <packaging>bundle</packaging>
    +
    +  <name>Apache Gora :: Ignite</name>
    +  <url>http://gora.apache.org</url>
    +  <description>The Apache Gora open source framework provides an in-memory data model and
    +    persistence for big data. Gora supports persisting to column stores, key value stores,
    +    document stores and RDBMSs, and analyzing the data with extensive Apache Hadoop MapReduce
    +    support.</description>
    +  <inceptionYear>2010</inceptionYear>
    +  <organization>
    +    <name>The Apache Software Foundation</name>
    +    <url>http://www.apache.org/</url>
    +  </organization>
    +  <issueManagement>
    +    <system>JIRA</system>
    +    <url>https://issues.apache.org/jira/browse/GORA</url>
    +  </issueManagement>
    +  <ciManagement>
    +    <system>Jenkins</system>
    +    <url>https://builds.apache.org/job/Gora-trunk/</url>
    +  </ciManagement>
    +
    +  <properties>
    +    <ignite.version>2.4.0</ignite.version>
    +    <osgi.import>*</osgi.import>
    +    <osgi.export>org.apache.gora.ignite*;version="${project.version}";-noimport:=true</osgi.export>
    +  </properties>
    +
    +  <build>
    +    <directory>target</directory>
    +    <outputDirectory>target/classes</outputDirectory>
    +    <finalName>${project.artifactId}-${project.version}</finalName>
    +    <testOutputDirectory>target/test-classes</testOutputDirectory>
    +    <testSourceDirectory>src/test/java</testSourceDirectory>
    +    <sourceDirectory>src/main/java</sourceDirectory>
    +    <testResources>
    +      <testResource>
    +        <directory>${project.basedir}/src/test/resources</directory>
    +        <includes>
    +          <include>**/*</include>
    +        </includes>
    +        <!--targetPath>${project.basedir}/target/classes/</targetPath -->
    +      </testResource>
    +    </testResources>
    +    <plugins>
    +      <plugin>
    +        <groupId>org.codehaus.mojo</groupId>
    +        <artifactId>build-helper-maven-plugin</artifactId>
    +        <version>${build-helper-maven-plugin.version}</version>
    +        <executions>
    +          <execution>
    +            <phase>generate-sources</phase>
    +            <goals>
    +              <goal>add-source</goal>
    +            </goals>
    +            <configuration>
    +              <sources>
    +                <source>src/examples/java</source>
    +              </sources>
    +            </configuration>
    +          </execution>
    +        </executions>
    +      </plugin>
    +    </plugins>
    +  </build>
    +
    +  <dependencies>
    +    <!-- Gora Internal Dependencies -->
    +    <dependency>
    +      <groupId>org.apache.gora</groupId>
    +      <artifactId>gora-core</artifactId>
    +    </dependency>
    +
    +    <dependency>
    +      <groupId>org.apache.gora</groupId>
    +      <artifactId>gora-core</artifactId>
    +      <type>test-jar</type>
    +      <scope>test</scope>
    +    </dependency>
    +
    +    <!--Ignite Dependency -->
    +    <dependency>
    +      <groupId>org.apache.ignite</groupId>
    +      <artifactId>ignite-core</artifactId>
    +      <version>${ignite.version}</version>
    +    </dependency>
    +
    +    <dependency>
    +      <groupId>commons-io</groupId>
    +      <artifactId>commons-io</artifactId>
    +    </dependency>
    +
    +    <dependency>
    +      <!-- Ignite mini was trying to load the Shell, which failed with the version of jline in the parent pom -->
    +      <groupId>jline</groupId>
    +      <artifactId>jline</artifactId>
    +      <version>2.11</version>
    +      <scope>test</scope>
    +    </dependency>
    +
    +    <dependency>
    +      <groupId>org.apache.zookeeper</groupId>
    +      <artifactId>zookeeper</artifactId>
    +      <scope>test</scope>
    +    </dependency>
    +
    +    <dependency>
    +      <groupId>org.apache.avro</groupId>
    +      <artifactId>avro</artifactId>
    +    </dependency>
    +    
    +    <dependency>
    +      <groupId>org.jdom</groupId>
    +      <artifactId>jdom</artifactId>
    +      <scope>compile</scope>
    +    </dependency>
    +
    +    <!-- Logging Dependencies -->
    +    <dependency>
    +      <groupId>org.slf4j</groupId>
    +      <artifactId>slf4j-log4j12</artifactId>
    +    </dependency>
    +    <dependency>
    +      <groupId>log4j</groupId>
    +      <artifactId>log4j</artifactId>
    +      <exclusions>
    +        <exclusion>
    +          <groupId>javax.jms</groupId>
    +          <artifactId>jms</artifactId>
    +        </exclusion>
    +      </exclusions>
    +    </dependency>
    +
    +    <!-- Testing Dependencies -->
    +    <dependency>
    +      <groupId>junit</groupId>
    +      <artifactId>junit</artifactId>
    +    </dependency>
    +
    +    <dependency>
    +      <groupId>org.apache.hadoop</groupId>
    +      <artifactId>hadoop-minicluster</artifactId>
    +    </dependency>
    +    
    +    <dependency>
    +      <groupId>org.apache.ignite</groupId>
    +      <artifactId>ignite-indexing</artifactId>
    +      <version>2.4.0</version>
    --- End diff --
    
    Please move this up to the other ignite dependency. Also consider defining the version as a constant somewhere. 


---