gora-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [gora] djkevincr commented on a change in pull request #156: GORA 411 - Add exists(key) to DataStore interface
Date Thu, 02 May 2019 05:45:55 GMT
djkevincr commented on a change in pull request #156: GORA 411 - Add exists(key) to DataStore
interface
URL: https://github.com/apache/gora/pull/156#discussion_r280293876
 
 

 ##########
 File path: gora-cassandra/src/main/java/org/apache/gora/cassandra/serializers/NativeSerializer.java
 ##########
 @@ -258,4 +259,26 @@ private K getKey(T object) {
     }
     return key;
   }
+
+  @Override
+  public boolean exists(Object key) throws GoraException {
 
 Review comment:
   @jhnmora000 If this code is same across  two native/avro serializers of Cassandra, lets
keep it in a common place. Eg: - CassandraSerializer.java removing the abstract method.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message