gora-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [gora] djkevincr commented on a change in pull request #156: GORA 411 - Add exists(key) to DataStore interface
Date Thu, 02 May 2019 06:02:29 GMT
djkevincr commented on a change in pull request #156: GORA 411 - Add exists(key) to DataStore
interface
URL: https://github.com/apache/gora/pull/156#discussion_r280295677
 
 

 ##########
 File path: gora-cassandra/src/main/java/org/apache/gora/cassandra/serializers/NativeSerializer.java
 ##########
 @@ -258,4 +259,26 @@ private K getKey(T object) {
     }
     return key;
   }
+
+  @Override
+  public boolean exists(Object key) throws GoraException {
 
 Review comment:
   +1, Please update the PR, I will locally test it and merge to the master. Also for the
cases where we had the default behavior Eg:- OrientDB Please create tickets for these. Those
implementations should be handled at client level.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message