hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Devaraj Das (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-6224) Add some utility methods to Text and DataOutputBuffer to be used by MAPREDUCE-318
Date Tue, 01 Sep 2009 12:36:32 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-6224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12749880#action_12749880
] 

Devaraj Das commented on HADOOP-6224:
-------------------------------------

bq.  One minor point: Would it be better readStringSafely move to WritableUtils?

Re-looking at the patch, i think it makes sense. +1

bq. One serious question: I am not sure why we need to open up the internal Buffer class of
DataOutputBuffer, or need to support the construction based on an external byte[]. For the
least, the ctor should clearly identify the ownership of the byte[]. But based on the implementation
of DataOutputBuffer, it seems that the ownership has to be transferred to DataOutputBuffer
and the caller of this ctor should not retain the reference to byte[].

HADOOP-6226 was opened to address this. I propose that we actually close that jira, and have
the implementation in the mapreduce package as part of MAPREDUCE-318

> Add some utility methods to Text and DataOutputBuffer to be used by MAPREDUCE-318
> ---------------------------------------------------------------------------------
>
>                 Key: HADOOP-6224
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6224
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: io
>            Reporter: Jothi Padmanabhan
>            Assignee: Jothi Padmanabhan
>             Fix For: 0.21.0
>
>         Attachments: common.patch
>
>
> MAPREDUCE-318 needs some minor extensions to the Text and the DataOutputBuffer classes.


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message