hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-6227) Configuration does not lock parameters marked final if they have no value.
Date Tue, 01 Sep 2009 12:56:32 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-6227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12749892#action_12749892
] 

Hadoop QA commented on HADOOP-6227:
-----------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12418238/patch-6227.txt
  against trunk revision 809491.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/4/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/4/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/4/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/4/console

This message is automatically generated.

> Configuration does not lock parameters marked final if they have no value.
> --------------------------------------------------------------------------
>
>                 Key: HADOOP-6227
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6227
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: conf
>            Reporter: Hemanth Yamijala
>             Fix For: 0.20.1
>
>         Attachments: patch-6227-0.20.txt, patch-6227.txt
>
>
> A use-case: Recently, we stumbled on a bug that wanted us to disable the feature to run
a debug script in map/reduce on tasks that fail, specified by mapred.{map|reduce}.task.debug.script.
The best way of disabling it seemed to be to set it with no value in the cluster configuration
and mark it final. This did not work, however, because the code in configuration explicitly
checks if the value is not null before adding it to the list of final parameters.
> Without an ability to do this, there might be a need to explicitly have a special way
of disabling optional features.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message