hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Boris Shkolnik (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-6864) Provide a JNI-based implementation of ShellBasedUnixGroupsNetgroupMapping (implementation of GroupMappingServiceProvider)
Date Fri, 23 Jul 2010 18:18:51 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-6864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12891703#action_12891703

Boris Shkolnik commented on HADOOP-6864:

1. put a comment before (and other places, including C code)
 users = getUsersForNetgroupJNI(netgroup.substring(1)); 
2. instead  Arrays.asList(new String[0]); - just construct an empty list.
3. Please put a disclaimer that JNI implementation returns only groups which appear in the
4. synchronize excess to the JNI functionality
5. Please test valid and invalid cases (empty or non-existing groups)..
6. Please test again :)

otherwise +1

> Provide a JNI-based implementation of ShellBasedUnixGroupsNetgroupMapping (implementation
of GroupMappingServiceProvider)
> -------------------------------------------------------------------------------------------------------------------------
>                 Key: HADOOP-6864
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6864
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: security
>            Reporter: Erik Steffl
>             Fix For: 0.22.0
>         Attachments: HADOOP-6864-0.20.1xx.patch
> The netgroups implementation of GroupMappingServiceProvider (see ShellBasedUnixGroupsNetgroupMapping.java)
does a fork of a unix command to get the netgroups of a user. Since the group resolution happens
in the servers, this might be costly. This jira aims at providing a JNI-based implementation
for GroupMappingServiceProvider.
> Note that this is similar to what https://issues.apache.org/jira/browse/HADOOP-6818 does
for implementation of GroupMappingServiceProvider that  supports only unix groups.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message