hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Boris Shkolnik (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-6855) Add ability to get groups for ACLs from 'getent netgroup'
Date Tue, 13 Jul 2010 17:33:50 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-6855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12887869#action_12887869

Boris Shkolnik commented on HADOOP-6855:

Here are some comments so far..
1. commented log lines Shellbasedunixgroup:122 and after could be removed

2. getNetgroups - returns list that is passed to it as an argument. Do you need this return
3. List groups = new LinkedList(netgroupToUsersMap.keySet()); - shouldn't it be a generic

4. ShellBasedUnixGroupsNetgroupMappingTestWrapper: execShellGetUnixGroups - seems to return
wrong data  - call for groups for user foo doesn't return user name as the first entry (not
sure if it is used in tests though).

5. Patch seems to introduce 2 new warnings:
ShellBasedUnixGroupsNetgroupMapping.java:60: warning: [unchecked] unchecked call to Lin
kedList(java.util.Collection<? extends E>) as a member of the raw type java.util.LinkedList
    [javac]     List groups = new LinkedList(netgroupToUsersMap.keySet());
    [javac]                   ^
    [javac] ShellBasedUnixGroupsNetgroupMapping.java:62: warning: [unchecked] unchecked conversion
    [javac] found   : java.util.List
    [javac] required: java.util.List<java.lang.String>
    [javac]     cacheGroupsAdd(groups);
    [javac]                    ^

> Add ability to get groups for ACLs from 'getent netgroup'
> ---------------------------------------------------------
>                 Key: HADOOP-6855
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6855
>             Project: Hadoop Common
>          Issue Type: New Feature
>          Components: security
>    Affects Versions: 0.22.0
>            Reporter: Erik Steffl
>             Fix For: 0.22.0
>         Attachments: HADOOP-6855-0.20.patch
> Add ability to specify netgroups in ACLs (see class AccessControlList.java). Membership
of users in netgroups will be determined by running 'getent negroups $groupName'. Netgroups
will be differentiated from regular unix groups by having '@' as a first character.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message