hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alejandro Abdelnur (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-6884) Add LOG.isDebugEnabled() guard for each LOG.debug("...")
Date Tue, 27 Jul 2010 22:57:16 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-6884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12892972#action_12892972
] 

Alejandro Abdelnur commented on HADOOP-6884:
--------------------------------------------

While common practice, this result in lot of code uglyfication/noise.

I'd rather suggest the following (we are doing this in Oozie):

Create a Log wrapper, XLog which extends Log and provides the following additional methods:

  info(String msgTemplate, Object ... args)
  warn(String msgTemplate, Object ... args)
  debug(String msgTemplate, Object ... args)
  trace(String msgTemplate, Object ... args)

In each one of these methods, if the log is enabled use the JDK MessageFormat class to create
the log message and call the corresponding Log method, else do nothing.

Caveat: the last args has to be tested for being a Throwable and if so the corresponding Log
method with (String, Throwable) signature.


> Add LOG.isDebugEnabled() guard for each LOG.debug("...")
> --------------------------------------------------------
>
>                 Key: HADOOP-6884
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6884
>             Project: Hadoop Common
>          Issue Type: Improvement
>    Affects Versions: 0.22.0
>            Reporter: Erik Steffl
>             Fix For: 0.22.0
>
>         Attachments: HADOOP-6884-0.22.patch
>
>
> Each LOG.debug("...") should be executed only if LOG.isDebugEnabled() is true, in some
cases it's expensive to construct the string that is being printed to log. It's much easier
to always use LOG.isDebugEnabled() because it's easier to check (rather than in each case
reason whether it's necessary or not).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message