hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Greg Roelofs (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-6837) Support for LZMA compression
Date Wed, 11 Aug 2010 23:51:24 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-6837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12897512#action_12897512

Greg Roelofs commented on HADOOP-6837:

bq. The currently patch carries a modified version of LZMA SDK. This is a huge maintenance
overhead going forward where a much simpler solution clearly exists.

If the modifications are rolled into the SDK, this issue goes away.  Nicholas, can you create
a current diff of the src/contrib part relative to lzma912's original path structure (i.e.,
so it applies cleanly to a stock lzma912 codebase)?  Then we can send it off to the 7Zip folks
and see if they're willing to incorporate it.

(And only "partly exists."  There's no Java in liblzma.  On the other hand, consensus around
here seems to be that built-in Java support isn't necessary.)

bq. It may be good to address the code style issue now, since this patch diverges significantly
from our standard

Only the src/contrib portion does, and that was intentional.  bzip2 is no longer actively
developed, so an in-tree, heavily modified port is no big deal.  LZMA, however, is still a
very active project, and if we ever wanted to upgrade to a newer release (e.g., for performance
or correctness reasons), we do _not_ want a lot of whitespace noise hiding the real diffs.

But this issue also largely disappears if the substantive modifications are accepted upstream;
then the formatting is fairly irrelevant, though still a pain for diffs and patches.  Either
way, I don't think style rules are or should necessarily be applicable to contrib code (in
the outside-the-core-codebase sense of "contrib").

> Support for LZMA compression
> ----------------------------
>                 Key: HADOOP-6837
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6837
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: io
>            Reporter: Nicholas Carlini
>            Assignee: Nicholas Carlini
>         Attachments: HADOOP-6837-lzma-1-20100722.non-trivial.pseudo-patch, HADOOP-6837-lzma-1-20100722.patch,
HADOOP-6837-lzma-2-20100806.patch, HADOOP-6837-lzma-3-20100809.patch, HADOOP-6837-lzma-4-20100811.patch,
HADOOP-6837-lzma-c-20100719.patch, HADOOP-6837-lzma-java-20100623.patch
> Add support for LZMA (http://www.7-zip.org/sdk.html) compression, which generally achieves
higher compression ratios than both gzip and bzip2.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message